There are several issues with this patch and I'm really tempted to just say "No." as it got two deadline extensions, both missed. Also it rotted for few weeks on reviewboard and there was plenty of time to finish it. The core feature works, though the code needs updating. Thanks to Dominik for starting it, I'm about to finish this patch.
Next time it will be plain "No.". -- Martin Klapetek | KDE Developer 2011/12/28 Dominik Cermak <[email protected]> > Am Mittwoch, 28. Dezember 2011, 18:59:07 schrieb Francesco Nwokeka: > > Sorry but I have to run and I ran into compatibility problems with the > > repo (have no clue why). This is the patch with the corrections made. > > I modified it to leave KButtonGroup. It crashed everytime because you > removed > it from the view, but not adapted the code. > > Not sure if it can be included in this state. It's Martin's desicion. > _______________________________________________ > KDE-Telepathy mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/kde-telepathy > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
