> On Jan. 6, 2012, 2:51 p.m., George Kiagiadakis wrote: > > src/add-account-assistant.cpp, line 190 > > <http://git.reviewboard.kde.org/r/103637/diff/1/?file=45808#file45808line190> > > > > Hm, syncrhonous dbus calls... Do I assume right that this waits for > > packagekit to do the whole installation before it returns?
yes, it does wait untill packagekit returns. > On Jan. 6, 2012, 2:51 p.m., George Kiagiadakis wrote: > > src/add-account-assistant.cpp, lines 177-178 > > <http://git.reviewboard.kde.org/r/103637/diff/1/?file=45808#file45808line177> > > > > These names will work for debian-based distros (which are not using > > packagekit by default btw :P), but I don't think every distro uses these > > names... the package names are valid for debian, opensuse, arch and gentoo. as suggested one could let the pacakger specify the package names via cmake option like "-DPKG_NAME_TP_HAZE=telepathy-haze" etc. true, kubuntu ninjas remove package-kit and insert qapt calls. > On Jan. 6, 2012, 2:51 p.m., George Kiagiadakis wrote: > > src/add-account-assistant.cpp, line 186 > > <http://git.reviewboard.kde.org/r/103637/diff/1/?file=45808#file45808line186> > > > > Maybe it would be better using the kde semantic tags instead... > > > > http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics going to have a look there, atm it's just copy/paste + slight modification. - Florian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103637/#review9612 ----------------------------------------------------------- On Jan. 6, 2012, 1 p.m., Florian Reinhard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103637/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2012, 1 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > automagically install telepathy-gabble / -haze. > > needs kpackagekit installed. (not there by default for kubuntu, they patch > stuff to use qapt). > > We possibly want to add a cmake variable for the packagenames like kdenetwork > does. > > > Diffs > ----- > > src/add-account-assistant.cpp 3023cf9c63f8a2e5b32f88e4b633aa52680ca7c5 > > Diff: http://git.reviewboard.kde.org/r/103637/diff/diff > > > Testing > ------- > > Purged telepathy-gabble, installation was triggered. > > > Thanks, > > Florian Reinhard > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
