> On Jan. 16, 2012, 10:35 p.m., Dario Freddi wrote: > > The code is ok to me, although I don't really understand its purpose, but I > > trust you on that as I'm likely to be missing the big picture. > > David Edmundson wrote: > It's quite a small picture, if an account fails to connect (bad password, > network etc) if you have the mpris plugin running every time you change track > the KDED changes status which means the offline account tries to reconnect, > same for when you idle/come back. Which sucks. > > Obviously this requires a one line patch in the kded-module to be useful.
I reiterate my ship it :) - Dario ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103709/#review9880 ----------------------------------------------------------- On Jan. 16, 2012, 5 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103709/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2012, 5 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Add a property to GlobalPresence to set whether it can activate offline > accounts. > > This is for use in the kded which should never be trying to bring an offline > account online. Should help deal with accounts that can't connect, and > hopefully some progress on the infinite spinning wheel. > > > Diffs > ----- > > KTp/global-presence.h 01706b0 > KTp/global-presence.cpp 4fe4407 > > Diff: http://git.reviewboard.kde.org/r/103709/diff/diff > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
