----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103801/#review10124 -----------------------------------------------------------
context-menu.cpp <http://git.reviewboard.kde.org/r/103801/#comment8341> surely you should check m_contactInfoDialog first. Otherwise you can spawn multiple versions of it, and under your current system the first one would leak. context-menu.cpp <http://git.reviewboard.kde.org/r/103801/#comment8342> You don't need this method at all. check out the QDialog flag. Qt::WA_DeleteOnClose - David Edmundson On Jan. 27, 2012, 10:56 a.m., Dominik Cermak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103801/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2012, 10:56 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > Make contact-info dialog modeless so it doesn't block. > > > Diffs > ----- > > context-menu.h 48d0f9f > context-menu.cpp b2cb7b2 > > Diff: http://git.reviewboard.kde.org/r/103801/diff/diff > > > Testing > ------- > > > Thanks, > > Dominik Cermak > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
