----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104430/#review11929 -----------------------------------------------------------
Spotted some things after I'd had a cup of tea. src/presenceapplet.cpp <http://git.reviewboard.kde.org/r/104430/#comment9447> Should these both not be dialog.data()->deleteLater(); src/presenceapplet.cpp <http://git.reviewboard.kde.org/r/104430/#comment9448> alternately rather than messing about with QWeakPointers for the accountModel we could do accountsModel->setParent(dialog) just after we create the dialog. - David Edmundson On March 27, 2012, 9:49 p.m., Mikhail Krishtop wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104430/ > ----------------------------------------------------------- > > (Updated March 27, 2012, 9:49 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Adding "Add new contacts" button to ktp-presence-applet. Add contact button > use ktp-common-internals/Widgets add-contact-dialog. > > Delete "m_" prefix from "m_addContactAction". > Account model creates before dialog opens. > Account model seems to need ContactFactory "<< Tp::Connection::FeatureRoster" > property. So I remove all other from previous version. > > NOTE: this commit works only with add-contact-dialog already in > ktp-common-internals/Widgets. For previous patch go to kde bugtracker. > > > This addresses bug 292882. > http://bugs.kde.org/show_bug.cgi?id=292882 > > > Diffs > ----- > > CMakeLists.txt 48c679624e61548735c584e31f41f307a6327f3a > src/presenceapplet.h 9c0533fcd6ff1a048ac49211370b23556d469a3d > src/presenceapplet.cpp 53e23b171052acc3f5fa1e5b8d42b101d1d817b1 > > Diff: http://git.reviewboard.kde.org/r/104430/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/104430/s/498/ > > > Thanks, > > Mikhail Krishtop > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
