-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105515/
-----------------------------------------------------------
(Updated July 11, 2012, 2:35 p.m.)
Review request for Telepathy.
Changes
-------
Edit a commit to fix a small omission
Description
-------
Being annoyed by the fact that the presence applet shows the AddContactDialog
as a modal dialog (making plasma unusable in the meantime), I decided to move
the contact subscription logic inside the dialog and therefore eliminate code
duplication between the applet and the CL as well as make it easy to use the
dialog in a non-modal way.
This patch also adds the KTP_NO_EXPORT macro, which we should start using to
hide private symbols and prepare the library for frameworks.
Shortlog:
George Kiagiadakis (9):
AddContactDialog: Move function implementations inside the KTp namespace
ktp-export.h: Add KTP_NO_EXPORT macro
AddContactDialog: Move the contact creation logic from the presence
applet & CL inside the dialog
AddContactDialog: Remove public accessors for account and screen name
AddContactsDialog: Use QComboBox::setModel() instead of manually
populating it with entries from the model
AddContactDialog: Error out if the user did not specify a contact name
AddContactDialog: kDebug++
AddContactDialog: Use KMessageBox::sorry() instead of error() and enhance
the strings
AddContactDialog: Attribute copyright to myself
Diffs (updated)
-----
KTp/Widgets/add-contact-dialog.h cc65aa3f6a94884a83bd058e876cecc5e996fb85
KTp/Widgets/add-contact-dialog.cpp dfbd9aac870a4d82953820fa4feb28e3af9d7f3d
KTp/ktp-export.h 909c3ca9f1b8ddaed28c0fc15b2537da2a843760
Diff: http://git.reviewboard.kde.org/r/105515/diff/
Testing
-------
The dialog still seems to work as expected
Thanks,
George Kiagiadakis
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
