----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105556/#review15897 -----------------------------------------------------------
logviewer/entity-proxy-model.cpp <http://git.reviewboard.kde.org/r/105556/#comment12554> consider splitting this so it's easier to read if (!contact.isNull()) { if (contact->alias()... ) { return true; } } return false; It took me a little while to double check the logic, and simpler code is easier for you to maintain in 6 months when you're looking at it. This works though, so it's up to you. - David Edmundson On July 13, 2012, 4:52 p.m., Dan Vratil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105556/ > ----------------------------------------------------------- > > (Updated July 13, 2012, 4:52 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > The EntityView improvements I made previously only support filtering by real > name (Tp::Contact::alias()), but sometimes you might want to filter contacts > by their account name (Tpl::Entity::alias()) instead of real name. > > When real names are not available (you are offline), view is filtered only by > account names. > > > Diffs > ----- > > logviewer/entity-proxy-model.cpp e431cd0 > > Diff: http://git.reviewboard.kde.org/r/105556/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vratil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
