----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105733/#review16442 -----------------------------------------------------------
I'm afraid renaming .desktop files to .in files is going to make them untranslatable... Better check with the translators first. - George Kiagiadakis On July 25, 2012, 11:12 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105733/ > ----------------------------------------------------------- > > (Updated July 25, 2012, 11:12 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Store the KTp version in CMakeKtpVersion.txt, all references to this version > then use this version number thanks to some configure_file. > When making a release this can then just be copied and pasted between repos, > rather than having to hunt for everything, which should make releases easier. > > If this gets the go-ahead, I'll update all other repos to follow a very > similar pattern. > > Note: because I edited some .desktop files it appears as massive diffs, I > only edited the version line. > A lot of these desktop files need quite some fixing, but it's not related to > this patch. > > Note 2: I haven't done the plasmoid in this repo. > > > Diffs > ----- > > CMakeKtpVersion.txt PRE-CREATION > CMakeLists.txt a5a3826 > app/main.cpp 4c75137 > config.h.in PRE-CREATION > filters/emoticons/CMakeLists.txt 6ba9b27 > filters/emoticons/ktptextui_message_filter_emoticons.desktop 7d9ee8e > filters/emoticons/ktptextui_message_filter_emoticons.desktop.in > PRE-CREATION > filters/formatting/CMakeLists.txt 11741f0 > filters/formatting/ktptextui_message_filter_formatting.desktop 316b4e3 > filters/formatting/ktptextui_message_filter_formatting.desktop.in > PRE-CREATION > filters/images/CMakeLists.txt f09c1f4 > filters/images/ktptextui_message_filter_images.desktop 58d03bb > filters/images/ktptextui_message_filter_images.desktop.in PRE-CREATION > logviewer/main.cpp 54af921 > > Diff: http://git.reviewboard.kde.org/r/105733/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
