----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107154/#review21271 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On Oct. 31, 2012, 3:19 p.m., Daniele Elmo Domenichelli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107154/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2012, 3:19 p.m.) > > > Review request for Telepathy, David Edmundson and Lasath Fernando. > > > Description > ------- > > [Requires review 107151]* > > Add property X-KTp-PluginInfo-Version to plugins > > This property holds the ktp-text-ui plugin framework version for which the > plugin is written, and allow us to switch the branch easily, without caring > of removing uncompatible plugins. This also allows us to "disable" plugins if > there is a problem just by bumping the version without updating it for that > plugin. > > I would like to merge this in stable branch, and bump version to 2 in master > and to 3 in filters branch > > > *Not really, I could change it to do it in some other ways, but it is nicer > using the version.h file and configuring it in CMakeLists.txt > > > Diffs > ----- > > CMakeLists.txt 1d1d72b877348ade85e4835e8e586b3c18ffc11e > filters/emoticons/ktptextui_message_filter_emoticons.desktop > ee8a51c23c553e1f1f3383531d79bcef314a3226 > filters/formatting/ktptextui_message_filter_formatting.desktop > 366de49363d72d879c0b3ae5baf442a846a9ab87 > filters/images/ktptextui_message_filter_images.desktop > 6dbbe591535d3202b2be8672fd25d7c63659d183 > filters/searchexpansion/ktptextui_message_filter_searchexpansion.desktop > 8b606c522d97152ad22e1dbcbb3b79db465685de > filters/texttospeech/ktptextui_message_filter_tts.desktop > 5e9810dc1926e3d2e76c1a0391fc07fab9e43725 > lib/ktptxtui_message_filter.desktop > c7d045337bcfeb7c6bf5096bc8397f756298987b > lib/plugin-config-manager.cpp b1a4d5b59a0a63f5b3f2a90ab81ca9a8f4e05693 > version.h.in PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/107154/diff/ > > > Testing > ------- > > Works, only the plugins with the correct version are loaded and displayed in > the plugin config dialog > > > Thanks, > > Daniele Elmo Domenichelli > >
_______________________________________________ KDE-Telepathy mailing list KDE-Telepathy@kde.org https://mail.kde.org/mailman/listinfo/kde-telepathy
