----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107269/#review21756 -----------------------------------------------------------
Ship it! Ship It! - Dan Vrátil On Nov. 9, 2012, 10:38 p.m., Daniele Elmo Domenichelli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107269/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2012, 10:38 p.m.) > > > Review request for Telepathy, David Edmundson and Dan Vrátil. > > > Description > ------- > > Basically the first time that the log is loaded, processStoredEvents was > called just once, all the other times it was called twice, by > onLoadFinished() and by onEventsLoaded(). > I'm still not convinced about the reason, perhaps a race condition between > the two methods (onLoadFinished starts asyncronously when the page is loaded > after initialise in onEventsLoaded), but it looks very deterministic (never > happens the first time, and happens always from the second time), perhaps it > is related to theme loading. > > Anyway, the loadFinished signal is emitted when the page is loaded, after > that initialise(headerInfo) sets the page template, therefore it is the best > place to call processStoredEvents(). > > 0.5 branch is ok? > > > This addresses bug 309828. > http://bugs.kde.org/show_bug.cgi?id=309828 > > > Diffs > ----- > > logviewer/message-view.h 0c90ded700f1d5435d96b583522432486dc51067 > logviewer/message-view.cpp 012c3b717b4b0e06af1c77def2ab38ed6b30e1f0 > > Diff: http://git.reviewboard.kde.org/r/107269/diff/ > > > Testing > ------- > > Loaded several logs both single and multi users, works > > > Thanks, > > Daniele Elmo Domenichelli > >
_______________________________________________ KDE-Telepathy mailing list KDE-Telepathy@kde.org https://mail.kde.org/mailman/listinfo/kde-telepathy
