> On Nov. 21, 2012, 5:26 a.m., David Edmundson wrote: > > Note: merging this is on hold as I want to change GlobalContactManager. > > Will update this in due course > > Martin Klapetek wrote: > Any updates on this? > > Rohan Garg wrote: > Sorry about the namespaces bits :(
@Martin, it needs a rewrite because some idiot (me) changed KTp::ContactRequestHandler. Pester me. @Rohan, no problem. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107203/#review22276 ----------------------------------------------------------- On Nov. 20, 2012, 10:44 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107203/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2012, 10:44 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > Port ContactRequestHandler to use new GlobalContactManager class > > This removes a lot of code \o/ and is generally more readable. > Also links the account to the newly added contact which will be useful for a > future patche. > > -- > > Code Tidy. Do not use "using namespace" in a header file. > > Doing so means any file that happens to include this header now has a > namespace implicitly set. This breaks the entire point of namespaces. > > CCMAIL: rohang...@kubuntu.org > > > Diffs > ----- > > contact-request-handler.h 43456ee8f0a354ed075335d80a125da51713a0e9 > contact-request-handler.cpp ea24885970f46cecc58000d3330a3e2be2d39581 > contactnotify.h 462b3f3fe5f00efd330b0e07da52422b0b30ee74 > contactnotify.cpp 65bdaac8d273eb0a3d76eee406e34877e1649e59 > > Diff: http://git.reviewboard.kde.org/r/107203/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list KDE-Telepathy@kde.org https://mail.kde.org/mailman/listinfo/kde-telepathy
