----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108960/#review27481 -----------------------------------------------------------
Ship it! mainwindow.cpp <http://git.reviewboard.kde.org/r/108960/#comment20651> Q_FOREACH(const KUrl &url, m_urls) we use const & this to save doing a copy as we loop through the list. Which makes things faster. (you even did it earlier!) - David Edmundson On Feb. 14, 2013, 10:18 p.m., Andrea Scarpino wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108960/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2013, 10:18 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > = summary > > > This addresses bug 288557. > http://bugs.kde.org/show_bug.cgi?id=288557 > > > Diffs > ----- > > ktp-send-file.desktop 9032bda > main.cpp fac970b > mainwindow.h 2c235b7 > mainwindow.cpp c968cf0 > mainwindow.ui e2431d2 > > Diff: http://git.reviewboard.kde.org/r/108960/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Send three files from dolphin > > http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/send-files.png > > > Thanks, > > Andrea Scarpino > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
