> On Feb. 19, 2013, 1:46 a.m., David Edmundson wrote: > > KTp/Declarative/contact-list.cpp, line 95 > > <http://git.reviewboard.kde.org/r/109033/diff/1/?file=114392#file114392line95> > > > > We shouldn't change a declarative plugin to match what one of the > > user's of the plugin wants. This changes the behaviour of ktp-active and we > > should be thinking about making things general. > > > > However, I think that won't ever need to delegate, so I'll allow this > > patch. > > > >
Well, not forcing a compile-time value (like this "true" does) is good towards a more generic system. FWIW, I don't think we should favor ktp-text-ui programatically. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109033/#review27695 ----------------------------------------------------------- On Feb. 19, 2013, 1:28 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109033/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2013, 1:28 a.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > This patch makes it possible to start conversations from the contact list > plasmoid. I think it's a good start into making out of the ktp-chat a useful > tool. > It's not cool to ask people to ping you if you want to talk with them on the > ktp-chat for the first time... ;) > > > Diffs > ----- > > KTp/Declarative/contact-list.cpp 58da5ab > > Diff: http://git.reviewboard.kde.org/r/109033/diff/ > > > Testing > ------- > > It works, although I'm unsure if it does what I think it does > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
