-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109051/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

I think the patch is quite self-explanatory. Keep all the delegates in memory 
while showing. It could be a problem if the conversation grows _a lot_ but it 
has to grow a lot.

Possible ways to solve it:
- limit the log lines that we'll be displaying. We're talking about a plasmoid 
anyway. If the user wants to read the log, he'll use ktp-log-viewer.
- set interactive to false. Then we can scroll as much we want, but not with 
the scrollbar
- buy a better aleix


Diffs
-----

  chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 2d13dba 

Diff: http://git.reviewboard.kde.org/r/109051/diff/


Testing
-------

You don't really want to know... It mostly involves that file: 
http://paste.kde.org/676436/


Thanks,

Aleix Pol Gonzalez

_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy

Reply via email to