----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109089/#review27892 -----------------------------------------------------------
A few things I don't understand. chat/org.kde.ktp-chat/contents/ui/main.qml <http://git.reviewboard.kde.org/r/109089/#comment20911> How could Math.min(width, height) return a negative number? or to phrase it another way, what's the point of the Math.max(0, x) chat/org.kde.ktp-chat/contents/ui/main.qml <http://git.reviewboard.kde.org/r/109089/#comment20912> would chilrenRect.height be easier be easier for the preferredSizes ? Not forcing it, just offering a suggestion. chat/org.kde.ktp-chat/contents/ui/main.qml <http://git.reviewboard.kde.org/r/109089/#comment20913> Why +3 ? And why both models? You can't have something in the conversations model that isn't in the pinnedModel can you? - David Edmundson On Feb. 22, 2013, 3:53 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109089/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2013, 3:53 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > We had a bug regarding the sizes of the main view. I found out it all was > caused by the minimum sizes calculation. > > This fixes this bug by giving a better minimum size instead of just implying > that we have 1 size and it's the current one. Furthermore, this makes it > possible to have items that are thinner than a square, which makes the whole > plasmoid a bit more flexible. > > > This addresses bug 315550. > http://bugs.kde.org/show_bug.cgi?id=315550 > > > Diffs > ----- > > chat/org.kde.ktp-chat/contents/ui/main.qml 3a9b74d > > Diff: http://git.reviewboard.kde.org/r/109089/diff/ > > > Testing > ------- > > I played with it for a while with 2 contacts, it felt much better and no > warnings in the console. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
