----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109137/#review27996 -----------------------------------------------------------
Ship it! I think it's ok, but I want d_ed to ship it as well as I don't follow the plasmoid side. Below some coding style issues to fix ;). KTp/Declarative/filtered-pinned-contacts-proxy-model.h <http://git.reviewboard.kde.org/r/109137/#comment20958> QAbstractItemModel* sourceModel -> QAbstractItemModel *sourceModel KTp/Declarative/filtered-pinned-contacts-proxy-model.h <http://git.reviewboard.kde.org/r/109137/#comment20959> QObject* parent -> QObject *parent KTp/Declarative/filtered-pinned-contacts-proxy-model.h <http://git.reviewboard.kde.org/r/109137/#comment20960> QModelIndex& source_parent -> QModelIndex &source_parent KTp/Declarative/filtered-pinned-contacts-proxy-model.cpp <http://git.reviewboard.kde.org/r/109137/#comment20961> QObject* parent -> QObject *parent KTp/Declarative/filtered-pinned-contacts-proxy-model.cpp <http://git.reviewboard.kde.org/r/109137/#comment20962> QModelIndex& source_parent -> QModelIndex &source_parent - Martin Klapetek On Feb. 25, 2013, 5:21 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109137/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2013, 5:21 a.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > This adds a new class to substitute the: > visible: available && !alreadyChatting > > For some reason it's not responding to the dataChanged when alreadyChatting > changes, though. Does anybody know why? > > > Diffs > ----- > > KTp/Declarative/qml-plugins.cpp bd2a927 > KTp/Declarative/CMakeLists.txt f42252d > KTp/Declarative/filtered-pinned-contacts-proxy-model.h PRE-CREATION > KTp/Declarative/filtered-pinned-contacts-proxy-model.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109137/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
