----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109161/#review28089 -----------------------------------------------------------
filters/highlight/highlight-filter.cpp <http://git.reviewboard.kde.org/r/109161/#comment21014> Not used filters/highlight/highlight-filter.cpp <http://git.reviewboard.kde.org/r/109161/#comment21013> Not used filters/highlight/highlight-filter.cpp <http://git.reviewboard.kde.org/r/109161/#comment21015> I think it makes more sense to check just the relevant account. 1) because I have a never have two account manager's in the same app rule. It's bad. 2) It makes more sense. You have access to the relevant account in the context parameter. filters/highlight/highlight-filter.cpp <http://git.reviewboard.kde.org/r/109161/#comment21012> This shouldn't be inside the loop. filters/highlight/highlight-filter.cpp <http://git.reviewboard.kde.org/r/109161/#comment21016> The main point of the highlight plugin isn't to put something in red but to emit a different notification. That's why we set the property. Ideally this means porting the text-ui notifyAboutIncomingMessage to take a KTp::Message object Putting your name in red doesn't really achieve anything, I know what my name looks like. Adium themes have a special class that should get set. - David Edmundson On Feb. 25, 2013, 11:46 p.m., Lasath Fernando wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109161/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2013, 11:46 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > This one was fairly straight forward. Just had to fix some build issues and > update the metadata file. > > > Diffs > ----- > > filters/CMakeLists.txt ac25a17 > filters/highlight/CMakeLists.txt PRE-CREATION > filters/highlight/highlight-filter.h PRE-CREATION > filters/highlight/highlight-filter.cpp PRE-CREATION > filters/highlight/ktptextui_message_filter_highlight.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109161/diff/ > > > Testing > ------- > > Wrote my name. Felt like in primary school. > > > Thanks, > > Lasath Fernando > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
