----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109202/#review28275 -----------------------------------------------------------
app/chat-window.cpp <http://git.reviewboard.kde.org/r/109202/#comment21120> Do we still need this? lib/chat-text-edit.cpp <http://git.reviewboard.kde.org/r/109202/#comment21123> This won't work if you set the send message shortcut to shift + enter. e->modifiers() is now non zero, so we would skip sending the message. I think we want e->matches(m_sendMessageAction->shortcut()); lib/chat-widget.h <http://git.reviewboard.kde.org/r/109202/#comment21121> and this lib/chat-widget.cpp <http://git.reviewboard.kde.org/r/109202/#comment21122> do we need this? Can you make sure the following works: - shortcut set to Enter pressing enter sends the message pressing shift + enter creates a new line - shortcut set to shift+enter pressing enter creates a new line pressing shift+enter sends the message - David Edmundson On Feb. 28, 2013, 5:03 p.m., Roman Nazarenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109202/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2013, 5:03 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > The patch is a mess. QTextEdit handles Key_Return, we need to save Key_Return > from passing to QTextEdit, but we need to know KAction shortcut. And that > shortcut is stored in ChatWindow, which is located far away in the QObject > parenting tree. > This patch allows user to configure custom shortcut, but standard shortcut > (Key_Return) is still working. I have no idea how to disable it without types > casting hell. > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=308894. > > http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=308894 > > > Diffs > ----- > > app/chat-window.h 018e91a > app/chat-window.cpp c79e3aa > lib/chat-text-edit.h 4279ce5 > lib/chat-text-edit.cpp 19fdb38 > lib/chat-widget.h 2c85f3b > lib/chat-widget.cpp e7adc5a > > Diff: http://git.reviewboard.kde.org/r/109202/diff/ > > > Testing > ------- > > > Thanks, > > Roman Nazarenko > >
_______________________________________________ KDE-Telepathy mailing list KDE-Telepathy@kde.org https://mail.kde.org/mailman/listinfo/kde-telepathy
