----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109183/#review28252 -----------------------------------------------------------
Ship it! filters/bugzilla/bugzilla-filter.h <http://git.reviewboard.kde.org/r/109183/#comment21145> Varname here. I see it's not used in many (all?) filters, should it just be (re)moved? filters/bugzilla/bugzilla-filter.cpp <http://git.reviewboard.kde.org/r/109183/#comment21149> I think this should be case-insensitive (and possibly make the colon optional too?) filters/bugzilla/bugzilla-filter.cpp <http://git.reviewboard.kde.org/r/109183/#comment21150> { on the new line filters/bugzilla/bugzilla-filter.cpp <http://git.reviewboard.kde.org/r/109183/#comment21151> Should we put the link also between the "..></a>" (as a display text)? filters/bugzilla/bugzilla-filter.cpp <http://git.reviewboard.kde.org/r/109183/#comment21147> const & (if it does not break the qvariant_cast below) filters/bugzilla/ktptextui_message_filter_bugzilla.desktop <http://git.reviewboard.kde.org/r/109183/#comment21112> This should be 0.6 - Martin Klapetek On Feb. 26, 2013, 6:09 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109183/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2013, 6:09 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Add a new filter that turns messages containg bugzilla bug URL's into > displaying the full title + status (lasath) > Move bugzilla querying into the client (me) > > This allows everything to happen asynchronously, meaning we don't block the > UI and we can show the message instantly > > It demos that we don't need message processor to be async, which greatly > simplifies things. > > > Also removed some invalid linker lines. > > > Diffs > ----- > > filters/images/CMakeLists.txt 33bdbc9 > filters/texttospeech/CMakeLists.txt 8f25696 > filters/formatting/CMakeLists.txt 1bb818c > filters/emoticons/CMakeLists.txt 5054e8d > filters/bugzilla/showBugzillaInfo.js PRE-CREATION > filters/bugzilla/ktptextui_message_filter_bugzilla.desktop PRE-CREATION > filters/bugzilla/bugzilla-filter.h PRE-CREATION > filters/bugzilla/bugzilla-filter.cpp PRE-CREATION > filters/bugzilla/CMakeLists.txt PRE-CREATION > filters/CMakeLists.txt d21f619 > > Diff: http://git.reviewboard.kde.org/r/109183/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list KDE-Telepathy@kde.org https://mail.kde.org/mailman/listinfo/kde-telepathy
