----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109232/#review28347 -----------------------------------------------------------
There's lots of unneeded stuff in this patch and lots of whitespace leftovers; should be simple few lines remove-one line added patch contact-delegate.cpp <http://git.reviewboard.kde.org/r/109232/#comment21166> Don't remove this line tooltips/contacttooltip.h <http://git.reviewboard.kde.org/r/109232/#comment21165> You don't need this tooltips/contacttooltip.cpp <http://git.reviewboard.kde.org/r/109232/#comment21164> Not needed tooltips/contacttooltip.cpp <http://git.reviewboard.kde.org/r/109232/#comment21162> This shouldn't be part of this patch tooltips/contacttooltip.cpp <http://git.reviewboard.kde.org/r/109232/#comment21160> You don't need this at all tooltips/ktooltip.h <http://git.reviewboard.kde.org/r/109232/#comment21161> Not needed - Martin Klapetek On March 1, 2013, 4:54 p.m., Alin M Elena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109232/ > ----------------------------------------------------------- > > (Updated March 1, 2013, 4:54 p.m.) > > > Review request for Telepathy, David Edmundson and Dan Vrátil. > > > Description > ------- > > is uses the new avatarPixmap() method to display avatars. > both the list and the tooltip will show gray avatars if offline.. show info > is still full colour... intentional... > > > This addresses bug 315965. > http://bugs.kde.org/show_bug.cgi?id=315965 > > > Diffs > ----- > > contact-delegate-compact.cpp ee2e668 > contact-delegate.h 9f0e5df > contact-delegate.cpp 810594a > tooltips/contacttooltip.h 60e8428 > tooltips/contacttooltip.cpp 712c4e2 > tooltips/ktooltip.h a1e8289 > > Diff: http://git.reviewboard.kde.org/r/109232/diff/ > > > Testing > ------- > > offline avatars are gray now... > > > Thanks, > > Alin M Elena > >
_______________________________________________ KDE-Telepathy mailing list KDE-Telepathy@kde.org https://mail.kde.org/mailman/listinfo/kde-telepathy
