> On March 3, 2013, 4:31 p.m., David Edmundson wrote: > > global-presence-chooser.h, line 50 > > <http://git.reviewboard.kde.org/r/109262/diff/1/?file=116710#file116710line50> > > > > We have a general rule of always putting "virtual" in the declaration > > when we override a method that's already virtual. > > > > I think it's more of a style thing.
Not only style. If we'll use this box with KComboBox* pointer, it won't work with this overlay properly due to unvirtual function. I was actually just being confused a bit with virtuality (thought non-virtual functions behave as virtual ones really do and vice versa). Fixed in new diff. - Roman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109262/#review28454 ----------------------------------------------------------- On March 3, 2013, 4:55 p.m., Roman Nazarenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109262/ > ----------------------------------------------------------- > > (Updated March 3, 2013, 4:55 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > busyOverlay now hides if presence chooser is editable. > > > This addresses bug 292282. > http://bugs.kde.org/show_bug.cgi?id=292282 > > > Diffs > ----- > > global-presence-chooser.h d7a19c4 > global-presence-chooser.cpp 9e7994f > > Diff: http://git.reviewboard.kde.org/r/109262/diff/ > > > Testing > ------- > > > Thanks, > > Roman Nazarenko > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
