----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109375/#review28852 -----------------------------------------------------------
This review has been submitted with commit d5940e72562fc2f9ffac6b033e4826729b5f5577 by David Edmundson to branch master. - Commit Hook On March 9, 2013, 6:45 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109375/ > ----------------------------------------------------------- > > (Updated March 9, 2013, 6:45 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Don't add pointless margin to presence applet > > Makes icon appear the same size as other icons in sys-tray > Remove duplicate setMinimumSize (we shouldn't be setting it when not in the > panel) > > > It was added for some important reason at the time which we can't remember > but that doesn't seem to be valid now > (a prime example of why you _always_ should comment any workarounds, unlike > me here.) > > > This addresses bug 309852. > http://bugs.kde.org/show_bug.cgi?id=309852 > > > Diffs > ----- > > presence/src/presence-applet.cpp acd6635 > > Diff: http://git.reviewboard.kde.org/r/109375/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Before > http://git.reviewboard.kde.org/media/uploaded/files/2013/03/09/before.png > After > http://git.reviewboard.kde.org/media/uploaded/files/2013/03/09/after.png > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
