----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109726/#review29898 -----------------------------------------------------------
Ship it! Ship It! - Martin Klapetek On March 26, 2013, 3:44 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109726/ > ----------------------------------------------------------- > > (Updated March 26, 2013, 3:44 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Fix crashes when using debug versions of Qt > > Rewrite the logic of sourceDataChanged which was fundamentally broken > This was potentially emitting onDataChanged on the invalid QModelIndex, > especially now we use a flat model in the filtered view > > > Diffs > ----- > > KTp/Models/contacts-model.cpp f472c9c538d48b8ff7b5fc63ce72e478835c71a5 > KTp/Models/contacts-filter-model.cpp > d3bfb326f54053c82f67124e7bc33278b1b77899 > KTp/Models/contacts-filter-model.h f5b41a505058be9b55703cd7cb6787c8d399bc7e > > Diff: http://git.reviewboard.kde.org/r/109726/diff/ > > > Testing > ------- > > Checked it no longer crashes; Online contacts count worked correctly when > Martin went offline and back. > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
