----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109696/#review29957 -----------------------------------------------------------
Ship it! Ship iit! and you can commit it to master now. contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml <http://git.reviewboard.kde.org/r/109696/#comment22329> our C++ coding style says you _need_ to add {} here for the one line if statements. We don't have a coding style for QML, but it probably applies the same. - David Edmundson On March 27, 2013, 1:49 p.m., Emil Sedgh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109696/ > ----------------------------------------------------------- > > (Updated March 27, 2013, 1:49 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > A filter for contacts > Keyboard navigation > ListItem highlighter > > > Diffs > ----- > > contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml b5ad784 > > Diff: http://git.reviewboard.kde.org/r/109696/diff/ > > > Testing > ------- > > It seems work both as standalone (plasma-windowed), desktop applet and menu > applet. > > > Thanks, > > Emil Sedgh > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
