----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109771/#review29974 -----------------------------------------------------------
lib/chat-widget.cpp <http://git.reviewboard.kde.org/r/109771/#comment22346> also could you add a comment why we're doing this. (just copy and paste what you put in the review description) - David Edmundson On March 27, 2013, 10:43 p.m., Eugene Shalygin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109771/ > ----------------------------------------------------------- > > (Updated March 27, 2013, 10:43 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > KTextEdit::setSpellCheckingLanguage() does not do anything if there is no > highlighter created yet, and KTextEdit::setCheckSpellingEnabled() does not > create it if there is no focus on widget. Therefore > d->ui.sendMessageBox->setSpellCheckingLanguage() call in > ChatWidget::loadSpellCheckingOption() is ignored. While this looks like > KTextEditor bug (espesially taking into account its documentation), just a > call to KTextEditor::createHighlighter() before setting language fixes this. > > And I moved loadSpellCheckingOption() because createHighlighter() results in > ChatWidget::onInputBoxChanged() call, where timers are used. > > > Diffs > ----- > > lib/chat-widget.cpp 8df51c1 > > Diff: http://git.reviewboard.kde.org/r/109771/diff/ > > > Testing > ------- > > > Thanks, > > Eugene Shalygin > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
