----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109787/#review30053 -----------------------------------------------------------
KTp/Declarative/pinned-contacts-model.cpp <http://git.reviewboard.kde.org/r/109787/#comment22405> We should either implement: virtual removeRows(...) AND virutal insertRows(...) or we handle insertion and removal using appendContactPin() removeContactPin() Proposed solution is a mixture of styles. besides this code already exists, just isn't being called (see below) KTp/Declarative/pinned-contacts-model.cpp <http://git.reviewboard.kde.org/r/109787/#comment22404> Here - David Edmundson On March 29, 2013, 1:17 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109787/ > ----------------------------------------------------------- > > (Updated March 29, 2013, 1:17 a.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > I guess this was broken during the persistent contacts refactoring. > > Implements it again > > > Diffs > ----- > > KTp/Declarative/pinned-contacts-model.h 01fabbb > KTp/Declarative/pinned-contacts-model.cpp 1701082 > > Diff: http://git.reviewboard.kde.org/r/109787/diff/ > > > Testing > ------- > > pinned and unpinned my imaginary friends > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
