> On Sept. 6, 2013, 4:45 p.m., Sven Brauch wrote: > > kpeople/uiplugins/imdetailswidget.cpp, line 29 > > <http://git.reviewboard.kde.org/r/112549/diff/3/?file=187421#file187421line29> > > > > Are you sure you want to use those pretty includes inside the library > > itself? From my last time trying to fix kpeople include paths I remember > > it's close to impossible to get it to work properly and cleanly. I'd feel > > better if the library would include its own files like #include "foo/bar.h".
Sorry I'm stupid. I read "kpeople/" and assumed this was inside the kpeople repo, but it's obviously not. Please ignore my comment. - Sven ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112549/#review39483 ----------------------------------------------------------- On Sept. 6, 2013, 2:18 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112549/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2013, 2:18 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > Add kpeople plugin to show IM contacts in show details view > > > Diffs > ----- > > kpeople/CMakeLists.txt 10c3758aa0fd54177595a69afd4eb899664b4193 > kpeople/uiplugins/CMakeLists.txt PRE-CREATION > kpeople/uiplugins/imdetailswidget.h PRE-CREATION > kpeople/uiplugins/imdetailswidget.cpp PRE-CREATION > kpeople/uiplugins/imdetailswidgetplugin.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112549/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Screenshot of show info dialog > > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/snapshot2_2.png > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
