----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112875/#review40442 -----------------------------------------------------------
Ship it! I think we can try this. Before shipping I want you to really really document the patch in the code explaining not just what it does but why. Make sure to commit this to the 0.7 branch. (or message me if you're not sure how) - David Edmundson On Sept. 21, 2013, 9:36 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112875/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2013, 9:36 p.m.) > > > Review request for Telepathy and Martin Klapetek. > > > Description > ------- > > This is related to https://bugs.kde.org/show_bug.cgi?id=302508 > http://commits.kde.org/telepathy-contact-applet/3b7a541d1ef8634b336ba9bd64a70dc4cc7027c3 > > The presence in applet is quite inaccurate when using requestedPresence as > its icon, while the problem is, if one of account doesn't support part of > presence which presence should be current presence. > > IMHO a better solution is to let currentPresence to be the one same as global > requested presence. So no matter in what case, the presence applet can show a > presence which an account actually is. > > If this passes the review I'd like to revert > http://commits.kde.org/telepathy-contact-applet/3b7a541d1ef8634b336ba9bd64a70dc4cc7027c3 > . > > > This addresses bug 302508. > http://bugs.kde.org/show_bug.cgi?id=302508 > > > Diffs > ----- > > KTp/global-presence.cpp 8e88be9 > > Diff: http://git.reviewboard.kde.org/r/112875/diff/ > > > Testing > ------- > > installed sault as the report, set to invisible, currentPresence is busy (I > have another gmail account supports hidden). > > > Thanks, > > Xuetian Weng > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
