----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112970/ -----------------------------------------------------------
(Updated Sept. 28, 2013, 7:56 p.m.) Review request for Telepathy. Changes ------- * Fix issues reported by David * Fix methods signatures to make explicit that it is the accountUID and not the path * Make the contactUID something like ktp://<account>#<contact> : As discussed with David this will allow us to use the contactUID to check if an contact is "our" or if someone else created it. Also make use of '#' instead of '_' because telepathy spec allows the '_' character in the account name. I'm adding this to this patch even if not related, because it will delete old contacts, in this way they are deleted only once. Description ------- uniqueIdentifier is guaranteed to be unique by telepathy, object paths coming from different service could hypotetically be non-unique, even though I believe that the specs require to append the uniqueIdentifier to "/org/freedesktop/Telepathy/"... anyway it is shorter and since it is the value returned as "account" from kpeople query, I believe it should be the same value saved in ~/.local/share/telepathy/mission-control/accounts.cfg Diffs (updated) ----- KTp/Models/accounts-tree-proxy-model.cpp c6002948093a22ecff9149651d41a030df838aa3 KTp/Models/kpeopletranslationproxy.cpp a9bce378271006a9003c7757e49ba5b76ea97223 kpeople/nepomuk-feeder/abstract-storage.h 952b4e0f492ac679f34d687cc26a4f5dba7e2718 kpeople/nepomuk-feeder/account.h 4ab64abb4280e7217966a19bda27017353902886 kpeople/nepomuk-feeder/account.cpp 161ea40ae609165a609a545b08a8d202dad07c1c kpeople/nepomuk-feeder/controller.cpp fa37b7e01734a2066261c3950d03f13ea034c02f kpeople/nepomuk-feeder/nepomuk-storage.h 3b712da642b7c728195c20ebb4b5516de911715d kpeople/nepomuk-feeder/nepomuk-storage.cpp 8e54a442ae7ee47ea93fb034cf73bc7469a03865 kpeople/nepomuk-feeder/tests/controller-test.h cdf690ce3b0adbddc6970a78abd0949bf0afaf03 kpeople/nepomuk-feeder/tests/controller-test.cpp aec56e2447dae41ec45f58c2971946b674c0aba9 Diff: http://git.reviewboard.kde.org/r/112970/diff/ Testing ------- Switched a few times from objectPath to uniqueIdentifier, contacts are updated (tested with nepomuk shell), contact list still works Thanks, Daniele E. Domenichelli
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
