> On Sept. 29, 2013, 3:24 a.m., David Edmundson wrote: > > KTp/im-persons-data-source.cpp, line 84 > > <http://git.reviewboard.kde.org/r/112987/diff/1/?file=193067#file193067line84> > > > > this can crash. > > > > if the account is offline, accountForContact won't work, at best it > > will return a null accountptr, which will then crash. > > > > This is important as it is called from onContactInvalidated.
I'm not sure what to return here when the account is null... something like ktp://invalid_account#<contact_id> would work? Can the contact be invalid as well? - Daniele E. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112987/#review40977 ----------------------------------------------------------- On Sept. 29, 2013, 12:35 a.m., Daniele E. Domenichelli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112987/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2013, 12:35 a.m.) > > > Review request for Telepathy, David Edmundson and Martin Klapetek. > > > Repository: ktp-common-internals > > > Description > ------- > > Use nco:contactUID instead of nco:imID to identify a contact > > NOTE: Changes in this review request > https://git.reviewboard.kde.org/r/112970/ are required for this to work > > > Diffs > ----- > > KTp/im-persons-data-source.cpp ebd01bae2f029ba5335c99babedec31b88cd7620 > KTp/Models/kpeopletranslationproxy.cpp > a9bce378271006a9003c7757e49ba5b76ea97223 > > Diff: http://git.reviewboard.kde.org/r/112987/diff/ > > > Testing > ------- > > Tested with contact list, changed presence a few times. > No more duplicates, presence works as expected > > > Thanks, > > Daniele E. Domenichelli > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
