----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113842/#review44239 -----------------------------------------------------------
KTp/Models/contacts-model.cpp <http://git.reviewboard.kde.org/r/113842/#comment31682> This should probably be outside the if(KTp::kpeopleEnabled()) KTp/Models/contacts-model.cpp <http://git.reviewboard.kde.org/r/113842/#comment31681> Try calling setNames here too. - David Edmundson On Nov. 22, 2013, 6:59 p.m., Siddhartha Sahu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113842/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 6:59 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > This is working only sporadically. > > Is it because of setSourceModel being called from elsewhere too. > The model seems to contain all the role names even when the sorting fails (in > which case sorting seems random) > > > Diffs > ----- > > KTp/Models/contacts-model.h e6fb7b1 > KTp/Models/contacts-model.cpp 0f69eb5 > > Diff: http://git.reviewboard.kde.org/r/113842/diff/ > > > Testing > ------- > > Not working perfectly yet. > > > Thanks, > > Siddhartha Sahu > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
