----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114137/#review44658 -----------------------------------------------------------
Note that we already do have avatars cache (at least for offline users anyway, when they are online, you don't need a cache) and KTp::Contact::avatarPixmap() should always return proper pixmap. Also, we now have a text chat capability checking in master, can you please add it here too? contact/src/contact-wrapper.cpp <http://git.reviewboard.kde.org/r/114137/#comment31881> I think this is supposed to be ::qObjectCast - Martin Klapetek On Nov. 26, 2013, 12:03 p.m., Alexandr Akulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114137/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2013, 12:03 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-desktop-applets > > > Description > ------- > > Port ContactWrapper capability getters from deprecated methods in > Tp::CapabilitiesBase to proper ones in KTp::Contact. > Next portion is to use KTp::Contact::avatarPixmap(), but it's delayed until > contacts and avatars cache be implemented. > > > Diffs > ----- > > contact/src/contact-wrapper.h 778a7a0 > contact/src/contact-wrapper.cpp b516960 > > Diff: http://git.reviewboard.kde.org/r/114137/diff/ > > > Testing > ------- > > Capability getters works as expected. > > > Thanks, > > Alexandr Akulich > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
