----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114196/#review44786 -----------------------------------------------------------
Ship it! Ship it! contact/src/contact-wrapper.cpp <http://git.reviewboard.kde.org/r/114196/#comment32013> This "if" is a bit pointless, the loop will do nothing if this list is empty. Probably not worth removing though. - David Edmundson On Nov. 29, 2013, 11:32 a.m., Alexandr Akulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114196/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2013, 11:32 a.m.) > > > Review request for Telepathy. > > > Bugs: 288556 > http://bugs.kde.org/show_bug.cgi?id=288556 > > > Repository: ktp-desktop-applets > > > Description > ------- > > Contact: Implemented files transfer by appropriate button. > > Added KIO dependency. > > > Diffs > ----- > > contact/CMakeLists.txt 7a9415b > contact/src/contact-wrapper.cpp b516960 > > Diff: http://git.reviewboard.kde.org/r/114196/diff/ > > > Testing > ------- > > It works! :-) > > > Thanks, > > Alexandr Akulich > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
