----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114444/#review45910 -----------------------------------------------------------
Ship it! Looks fine to me from the usability side. People who know nothing about nick completion might still not understand it, but they can just leave it unchanged. - Thomas Pfeiffer On Dec. 18, 2013, 4:14 p.m., Leon Handreke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114444/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2013, 4:14 p.m.) > > > Review request for Telepathy. > > > Bugs: 326756 > http://bugs.kde.org/show_bug.cgi?id=326756 > > > Repository: ktp-text-ui > > > Description > ------- > > Make nick completion style configurable > > > Diffs > ----- > > config/behavior-config.h fcbdd7f678a8d975751c44afbdcda61771a59f8b > config/behavior-config.cpp 9f863dca930f1b39587fc63207d1c92d096a6559 > config/behavior-config.ui 200f6ee4023e11e9101dd10774d8095fab2e0120 > lib/chat-text-edit.cpp 4e0f0305b7ae18062f695eb26ee681a0c64aaf26 > lib/text-chat-config.h 603c00615d8bd51249ebff4e14fa5b44a2e5af0a > lib/text-chat-config.cpp 7425d5ea03b67022db813c2fffcdcb51c572e759 > > Diff: http://git.reviewboard.kde.org/r/114444/diff/ > > > Testing > ------- > > Clicked around in the UI, verified that all options work. > > > File Attachments > ---------------- > > Screenshot of the config UI > > http://git.reviewboard.kde.org/media/uploaded/files/2013/12/18/98c4ac3e-88ba-4ae9-a9de-14287169fa8d__nickname-completion-screenshot.png > > > Thanks, > > Leon Handreke > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
