> On Nov. 28, 2013, 9:32 a.m., Martin Klapetek wrote: > > plugins/sipe/sipe-advanced-options-widget.ui, line 9 > > <https://git.reviewboard.kde.org/r/114121/diff/1/?file=220054#file220054line9> > > > > The dialog seems unnecessary wide? > > > > Also, pro tip - when doing UI changes, always post a screenshot of your > > result ;)
I adjusted size in designer, now (via special button). Sorry, I don't understand how to attach screenshots here... > On Nov. 28, 2013, 9:32 a.m., Martin Klapetek wrote: > > plugins/sipe/sipe-main-options-widget.ui, line 10 > > <https://git.reviewboard.kde.org/r/114121/diff/1/?file=220057#file220057line10> > > > > This on the other hand, seems to small? I think you can also just > > remove the absolute sizes from the .ui files I adjusted size in designer here too. I a bit dislike idea of removing sizes, because just openning and saving ui files in designer immidiatly returns them. - Maksim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114121/#review44659 ----------------------------------------------------------- On Dec. 26, 2013, 9:20 p.m., Maksim Melnikau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114121/ > ----------------------------------------------------------- > > (Updated Dec. 26, 2013, 9:20 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-accounts-kcm > > > Description > ------- > > telepathy-sipe e.g. pidgin-sipe telepathy's backend support > > > Diffs > ----- > > plugins/CMakeLists.txt e752ef1 > plugins/sipe/CMakeLists.txt PRE-CREATION > plugins/sipe/Messages.sh PRE-CREATION > plugins/sipe/ktpaccountskcm_plugin_sipe.desktop.cmake PRE-CREATION > plugins/sipe/sipe-account-ui-plugin.h PRE-CREATION > plugins/sipe/sipe-account-ui-plugin.cpp PRE-CREATION > plugins/sipe/sipe-account-ui.h PRE-CREATION > plugins/sipe/sipe-account-ui.cpp PRE-CREATION > plugins/sipe/sipe-advanced-options-widget.h PRE-CREATION > plugins/sipe/sipe-advanced-options-widget.cpp PRE-CREATION > plugins/sipe/sipe-advanced-options-widget.ui PRE-CREATION > plugins/sipe/sipe-main-options-widget.h PRE-CREATION > plugins/sipe/sipe-main-options-widget.cpp PRE-CREATION > plugins/sipe/sipe-main-options-widget.ui PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/114121/diff/ > > > Testing > ------- > > only basic testing done, not all advanced options tested > > > Thanks, > > Maksim Melnikau > >
_______________________________________________ KDE-Telepathy mailing list KDE-Telepathy@kde.org https://mail.kde.org/mailman/listinfo/kde-telepathy
