> On Jan. 15, 2014, 6:30 p.m., David Edmundson wrote: > > chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml, line 98 > > <https://git.reviewboard.kde.org/r/114993/diff/1/?file=233896#file233896line98> > > > > From theme.h this is wrong > > > > HighlightColor = 1, /**< the text highlight color to be > > used by items resting > > > > Text and Highlight must both be visible on Background, but there's no > > guarantee that Text will be visible on Highlight. > > > > We need > > font: theme.smallestFont
I suggest to check with bunch of top-rated plasma themes from kde-look.org and see how much it breaks - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114993/#review47461 ----------------------------------------------------------- On Jan. 13, 2014, 12:22 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114993/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2014, 12:22 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-desktop-applets > > > Description > ------- > > Resize notification bubble to fit text for large number of unread messages > > > Diffs > ----- > > chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml b08235c > > Diff: https://git.reviewboard.kde.org/r/114993/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
