> On Jan. 18, 2014, 2:20 a.m., Martin Klapetek wrote: > > File Attachment: kcm.png - kcm.png > > <https://git.reviewboard.kde.org/r/115076/#fcomment133> > > > > I'm not sure if duplicating this is a good idea...the rest yes, this > > button, not so sure. > > Thomas Pfeiffer wrote: > Genereally I don't think duplicating things is a problem. What might be a > problem here is that users might have difficulties finding the regular Add > Account button afterwards because they keep looking for it somewhere in the > accounts list. With QML, we could just put a big red arrow pointing to the > button in there instead of the duplicate button, but it might be difficult > with widgets... > > Martin Klapetek wrote: > Well you can just say "click the button on the right" ;) > > David Edmundson wrote: > You could put that, till it gets translated into Arabic. > > Personally I like the idea of being vaguely consistent with BlueDevil, > WebAccounts and the printer one. > I might even try and get this into ItemViews in Frameworks?
I have a proposal - let's leave this for 0.9 and change it to look/work as the print manager does - when there's nothing configured, don't display the white area at all (the empty listview), but put the "no accounts configured" widget instead of it (so it has a button background). Then move the buttons to the top and make them bigger. And finally, when/if there's no account, hide the controls that are not needed (the buttons on the top for adding/removing an account) and leave only the one button in the central widget. Or we could do it for 0.8 still, we're not in string freeze yet and should be fairly simple. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115076/#review47622 ----------------------------------------------------------- On Jan. 17, 2014, 3:56 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115076/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2014, 3:56 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-accounts-kcm > > > Description > ------- > > Display nice UI when no accounts are present, see screenshot > > > Diffs > ----- > > src/CMakeLists.txt cf7998e > src/accounts-list-view.h PRE-CREATION > src/accounts-list-view.cpp PRE-CREATION > src/kcm-telepathy-accounts.cpp c8b837b > src/main-widget.ui 4983c71 > > Diff: https://git.reviewboard.kde.org/r/115076/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > kcm.png > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/17/2880d55c-2c75-4706-9694-ef25fdd92f47__kcm.png > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
