----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116520/#review51500 -----------------------------------------------------------
Nice job. sendfiledialog.h <https://git.reviewboard.kde.org/r/116520/#comment36264> License sendfiledialog.h <https://git.reviewboard.kde.org/r/116520/#comment36266> ? sendfiledialog.h <https://git.reviewboard.kde.org/r/116520/#comment36265> I thought you were going to put this into ktp-common-internals/Widgets ? If you do, remember to add the namespace in here. Right now it's fine though sendfiledialog.cpp <https://git.reviewboard.kde.org/r/116520/#comment36269> license sendfiledialog.cpp <https://git.reviewboard.kde.org/r/116520/#comment36267> For spacing we follow this coding standard: http://techbase.kde.org/Policies/Kdelibs_Coding_Style Try to make sure the whole file follows this. sendfiledialog.cpp <https://git.reviewboard.kde.org/r/116520/#comment36268> This *needs* translating. i.e i18n("Send") - David Edmundson On March 1, 2014, 9:38 p.m., mayank jha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116520/ > ----------------------------------------------------------- > > (Updated March 1, 2014, 9:38 p.m.) > > > Review request for Telepathy. > > > Bugs: 331533 > http://bugs.kde.org/show_bug.cgi?id=331533 > > > Repository: ktp-send-file > > > Description > ------- > > Creates a new widget which renames the "Open" button to "Send". > > > Diffs > ----- > > sendfiledialog.cpp PRE-CREATION > sendfiledialog.h PRE-CREATION > main.cpp a35c4e1 > CMakeLists.txt 04ded76 > > Diff: https://git.reviewboard.kde.org/r/116520/diff/ > > > Testing > ------- > > Runs fine! > > > Thanks, > > mayank jha > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
