> On March 5, 2014, 7:47 a.m., Martin Klapetek wrote: > > src/handle-incoming-file-transfer-channel-job.cpp, lines 457-462 > > <https://git.reviewboard.kde.org/r/116606/diff/1/?file=252132#file252132line457> > > > > I don't think this is needed > > David Edmundson wrote: > What I think this patch will do is emit the dialog, but the notification > in the corner will happily say "SUCCESS!" > > I seem to remember it being rather difficult to stop that original > notification that is coming from the KIO jobtracker being stupid. It was > something that needed investigation (and testing :P) to fix properly. > > We don't want a new notification, we want to stop the original > notification lying. Sending a new notification on top will just make things > super confusing. > > > > Martin Klapetek wrote: > There's KJob::kill(Quietly), worth looking into.
I agree with everything said so far: - A failed file transfer is not something worth breaking the user's workflow, so it should be a notification (if the user asks herself what happened to that file transfer, she'll look at the notification area and see that it failed). - Having one notification that says "Success!" and one that says "Fail" is confusing. This should imo be fixed at the KIO level, because it's messed up in general. When I cancel any file transfer job (regardless of whether it's from KTp or Dolphin or whatever), it gives a success message as well, which is nonsense and it confuses me time and time again. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116606/#review52014 ----------------------------------------------------------- On March 5, 2014, 6:44 a.m., mayank jha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116606/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 6:44 a.m.) > > > Review request for Telepathy. > > > Bugs: 319025 > http://bugs.kde.org/show_bug.cgi?id=319025 > > > Repository: ktp-filetransfer-handler > > > Description > ------- > > Adds a QMessageBox to display relevant error message. > > > Diffs > ----- > > src/filetransfer-handler.cpp a5fa677 > src/handle-incoming-file-transfer-channel-job.cpp 36b8310 > > Diff: https://git.reviewboard.kde.org/r/116606/diff/ > > > Testing > ------- > > Compiles fine! Test pending. > > > Thanks, > > mayank jha > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
