> On March 5, 2014, 10:51 p.m., David Edmundson wrote: > > src/call-handler.h, line 27 > > <https://git.reviewboard.kde.org/r/116623/diff/2/?file=252345#file252345line27> > > > > why is this public? > > > > > > also if this can be at most 1 item, what's the benefit of making it a > > list? > > > > What would happen in the following circumstance: > > - I start a call > > - I end that call > > - I get a new call > > David Edmundson wrote: > Ninja edit: Actually I've just thought through what would happen in that > situation, and your code actually would be fine. > > I'm going to assume your decision was deliberate if you can explain to me > why it would work :)
What I thought is that, once we send a request for call manager for a particular call channel, it creates an entry in the QList and any subsequent calls will simply be ignored as it is already found. And getting/making a call does not really matter I guess, since channel would remain same! I thought it this way! :) And I made the choice of public and private arbitrarily, but I guess I should make it private for safety. - mayank ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116623/#review52212 ----------------------------------------------------------- On March 5, 2014, 10:38 p.m., mayank jha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116623/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 10:38 p.m.) > > > Review request for Telepathy. > > > Bugs: 309146 > http://bugs.kde.org/show_bug.cgi?id=309146 > > > Repository: ktp-call-ui > > > Description > ------- > > We store the channels handled by a callManager in a list, and upon a new > request we check if it already exists, only if it is new we open a new > call-ui window. > > > Diffs > ----- > > src/call-handler.cpp f4ced53 > src/call-handler.h 5fea003 > > Diff: https://git.reviewboard.kde.org/r/116623/diff/ > > > Testing > ------- > > Runs fine! > > > Thanks, > > mayank jha > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
