> On April 16, 2014, 11:44 p.m., David Edmundson wrote: > > lib/chat-widget.cpp, line 136 > > <https://git.reviewboard.kde.org/r/117573/diff/3/?file=266260#file266260line136> > > > > Why do we need to cast?
If I did the assignment without casting, the compiler will complain with error: invalid conversion from ‘int’ to ‘ShareProvider::ShareService’ [-fpermissive] I thought of make it returning a ShareProvider::ShareService enum instead of an int, but we are going to add #include "shareprovider.h" to the text-chat-config.h which I think it is not a good idea to include the whole header file for just an enum (correct me if I was wrong please). > On April 16, 2014, 11:44 p.m., David Edmundson wrote: > > image-sharer/cmake/modules/FindQJson.cmake, line 7 > > <https://git.reviewboard.kde.org/r/117573/diff/3/?file=266246#file266246line7> > > > > Where did you copy this from? > > > > We historically have had problems with FindQJson files I copied it from Choqok project, I am using QJson to parse the response from Imgur, if you have another good alternative I am happy to add it. > On April 16, 2014, 11:44 p.m., David Edmundson wrote: > > image-sharer/CMakeLists.txt, line 23 > > <https://git.reviewboard.kde.org/r/117573/diff/3/?file=266242#file266242line23> > > > > we need to make this name less generic to avoid lib clashes. > > > > OR > > > > build it static and don't install it Can you suggest a better naming ? Is ktp-text-ui-image-sharer ok or text-ui-image-sharer ? - Ahmed ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117573/#review55918 ----------------------------------------------------------- On April 18, 2014, 6:05 p.m., Ahmed Ibrahim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117573/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 6:05 p.m.) > > > Review request for Telepathy and David Edmundson. > > > Bugs: 322874 > http://bugs.kde.org/show_bug.cgi?id=322874 > > > Repository: ktp-text-ui > > > Description > ------- > > I've wrote an extensible image sharer library that can upload images to > Imgur, Simplest Image Host and ImageBin, the library can be extended to > support other services like wstaw.org for example. I've integrated the > library with text-ui and used it to share images to the choosed service when > dragging it to the text-ui. > > I've added a new "Image Sharing" configuration item under the Chat Tab > Behaviour, you will find the screenshot attached. > > > Diffs > ----- > > CMakeLists.txt eabecd9 > config/CMakeLists.txt a8e7cd9 > config/behavior-config.h d57fd90 > config/behavior-config.cpp eeb3597 > config/behavior-config.ui c8e731c > image-sharer/CMakeLists.txt PRE-CREATION > image-sharer/abstractsharer.h PRE-CREATION > image-sharer/abstractsharer.cpp PRE-CREATION > image-sharer/cmake/CMakeLists.txt PRE-CREATION > image-sharer/cmake/modules/FindQJson.cmake PRE-CREATION > image-sharer/imagebinsharer.h PRE-CREATION > image-sharer/imagebinsharer.cpp PRE-CREATION > image-sharer/imagesharer_export.h PRE-CREATION > image-sharer/imgursharer.h PRE-CREATION > image-sharer/imgursharer.cpp PRE-CREATION > image-sharer/mpform.h PRE-CREATION > image-sharer/mpform.cpp PRE-CREATION > image-sharer/shareprovider.h PRE-CREATION > image-sharer/shareprovider.cpp PRE-CREATION > image-sharer/simplestimagehostingsharer.h PRE-CREATION > image-sharer/simplestimagehostingsharer.cpp PRE-CREATION > lib/CMakeLists.txt d640536 > lib/chat-widget.h d9c4e60 > lib/chat-widget.cpp d130529 > lib/text-chat-config.h e0ba24f > lib/text-chat-config.cpp 57c7c0c > > Diff: https://git.reviewboard.kde.org/r/117573/diff/ > > > Testing > ------- > > Dragged an image to the text-ui and the image url is appended and sent to the > other endpoint of the conversation. > > > File Attachments > ---------------- > > A screenshot of an uploaded image to the three supported image sharing > services > > https://git.reviewboard.kde.org/media/uploaded/files/2014/04/14/1a00a5d6-dd2e-4b58-a25b-c456d4adc89e__ktp-text-ui-share.png > Image Sharing Settings under the Chat Tab Behaviour > > https://git.reviewboard.kde.org/media/uploaded/files/2014/04/14/546bdac8-a803-48ac-a79c-0b5a8ba2a392__snapshot4.png > Share Context Menu > > https://git.reviewboard.kde.org/media/uploaded/files/2014/04/15/9e23d7e0-4e79-4053-83f4-9062ef290647__ktp-text-ui-share-menu.png > > > Thanks, > > Ahmed Ibrahim > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
