> On April 26, 2014, 4:20 p.m., David Edmundson wrote: > > Ship It!
I don't have push access, could you please push it when you have the time? Thank you. - Renato ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117791/#review56634 ----------------------------------------------------------- On April 26, 2014, 4:09 p.m., Renato Atilio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117791/ > ----------------------------------------------------------- > > (Updated April 26, 2014, 4:09 p.m.) > > > Review request for Telepathy. > > > Bugs: 325506 > http://bugs.kde.org/show_bug.cgi?id=325506 > > > Repository: ktp-contact-list > > > Description > ------- > > I've fixed the 325506 bug by creating a decision upon the validity of the > inserted item's parent. If it is valid, it works as before, considering it is > a top-level element we want to collapse/expand. If it is invalid, the > inserted item itself is probably the top-level node (hence the invalid parent > - there's none), so we get it in another way. > > I don't think the second validity check is strictly needed, but I thought it > was safer to keep it anyway. > > > Diffs > ----- > > contact-list-widget.h c5b5328 > contact-list-widget.cpp ae1b9c9 > > Diff: https://git.reviewboard.kde.org/r/117791/diff/ > > > Testing > ------- > > > Thanks, > > Renato Atilio > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
