> On April 26, 2014, 5:52 p.m., David Edmundson wrote: > > tools/debugger/main-window.cpp, line 91 > > <https://git.reviewboard.kde.org/r/117793/diff/1/?file=268474#file268474line91> > > > > Maybe turn it into a list and qSort it? > > Ahmed Ibrahim wrote: > Why do we need to sort it ? Is it because it needs to be represented > alphabetically ?
QSet doesn't keep order; so it's basically random. It should be the same random order each time, so maybe it's not a problem.There's only a few tabs anyway. I'm not particularly fussed, I just thought it might be a nice improvement whilst you have the code open. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117793/#review56640 ----------------------------------------------------------- On April 26, 2014, 5:45 p.m., Ahmed Ibrahim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117793/ > ----------------------------------------------------------- > > (Updated April 26, 2014, 5:45 p.m.) > > > Review request for Telepathy. > > > Bugs: 303563 > http://bugs.kde.org/show_bug.cgi?id=303563 > > > Repository: ktp-common-internals > > > Description > ------- > > Removed the hard coded tabs of Haze, Rakia, Gabble and Salut. And made Only > online connection managers to be shown. > > > Diffs > ----- > > tools/debugger/main-window.h 67ea785 > tools/debugger/main-window.cpp eb607cc > tools/debugger/main-window.ui dd7dcc4 > > Diff: https://git.reviewboard.kde.org/r/117793/diff/ > > > Testing > ------- > > Got online with a Jabber account and found only Gabble tab, switched the MSN > account to online "Haze" tab is added. > > > Thanks, > > Ahmed Ibrahim > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
