----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118066/#review57670 -----------------------------------------------------------
This looks like a better way to prevent ticking plug-ins than the check in onPluginActivated(). This should also be applied to #116940 setMessagePluginActive() also, where it can work for the status plugins. Otherwise, the presence plugins usually only setActive() once on, and once off. - James Smith On May 9, 2014, 11:53 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118066/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 11:53 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-kded-module > > > Description > ------- > > Don't emit activateChanged signal if it hasn't changed > > > Diffs > ----- > > telepathy-kded-module-plugin.cpp daf73c6 > > Diff: https://git.reviewboard.kde.org/r/118066/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
