-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116940/
-----------------------------------------------------------
(Updated June 10, 2014, 6:02 a.m.)
Review request for Telepathy.
Changes
-------
Accommodation of additional functionality for the status message plugins led to
a new class with the important functions borrowed from the existing presence
plugin class.
Rate-limiting the status message plugins is now done when a certain number of
activations have been detected in a fixed amount of time, and the status
handler now keeps a list of the last n number of status messages.
Summary (updated)
-----------------
Add a new status message plugin class and use it for the now Playing plugin
Bugs: 332082 and 334542
http://bugs.kde.org/show_bug.cgi?id=332082
http://bugs.kde.org/show_bug.cgi?id=334542
Repository: ktp-kded-module
Description (updated)
-------
Move status message plugins into a separate class. New infrastructure to help
mitigate the occurrence of bug #334492 while using status message plugins: 1)
buffering of the last n status messages, and 2) a limiter to help stop flooding
the presence changer. Also strips redundant and disused data structures from
both classes.
This patch returns the ability to engage status message plug-ins from custom
status messages. Also working is the disabling of non-visible status message
plug-ins. State-affinity in the 95% of previously noted cases has been vastly
improved also, the few remaining issues should be due to "lite" protocols that
don't have a full complement of on-line presences.
Diffs (updated)
-----
telepathy-mpris.cpp 44b041f
telepathy-mpris.h 05b77c9
telepathy-kded-module-plugin.cpp daf73c6
telepathy-kded-module-plugin.h 4c16169
telepathy-kded-module-message-plugin.cpp PRE-CREATION
telepathy-kded-module-message-plugin.h PRE-CREATION
status-handler.cpp 4b9c25a
status-handler.h 06240ff
CMakeLists.txt 9302677
tests/CMakeLists.txt 7ec7749
Diff: https://git.reviewboard.kde.org/r/116940/diff/
Testing
-------
Disconnect / reconnect, autoconnect / no autoconnect, suspend / resume. Enable
/ disable via kcm module. Added a new custom presence and engaged the now
playing plugin in the contact list from the new presence. Disabled the plugin
by activating another presence.
Thanks,
James Smith
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
