> On June 11, 2014, 5:01 a.m., David Edmundson wrote: > > > > Its a mailto link already, what does this add? > > Martin Klapetek wrote: > It adds mailto: links to email addresses that are not mailto: links > already. But maybe that should be done in a different place? > > Olaf Piesche wrote: > Really? It's not for me - emails come through as plain text.
Yeah, I wasn't sure if the url expansion filter was the right place. I'll move it to its own filter. - Olaf ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118656/#review59740 ----------------------------------------------------------- On June 11, 2014, 12:18 a.m., Olaf Piesche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118656/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 12:18 a.m.) > > > Review request for Telepathy. > > > Bugs: 333527 > http://bugs.kde.org/show_bug.cgi?id=333527 > > > Repository: ktp-text-ui > > > Description > ------- > > Added e-mail recognition to the URL expansion filter as indicated in the bug. > Maybe move to its own filter? > > This does regex matching for e-mail addresses, replacing each with a mailto > link. This works with an arbitrary number of e-mail addresses in a message, > as long as the address is separated from the rest of the text. > > > Diffs > ----- > > filters/urlexpansion/urlexpansion-filter.cpp b39dd5e > > Diff: https://git.reviewboard.kde.org/r/118656/diff/ > > > Testing > ------- > > Sent multiple e-mail addresses in various configurations with and without > text around them back and forth. > > > File Attachments > ---------------- > > screen shot > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/11/652e641c-a8dd-4403-8de9-ecb24fc6a8ed__e-mail-expansion.jpg > > > Thanks, > > Olaf Piesche > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
