On Nov. 15, 2014, 4:11 a.m., Martin Klapetek wrote: > > Is this class not deprecated? In KPeople mode we don't use this dialog and > > kpeople was going to become a mandatory dependency.
Yes, once it's a mandatory dependecy, this should be deprecated. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121125/#review70386 ----------------------------------------------------------- On Nov. 14, 2014, 8:20 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121125/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 8:20 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > As summary; as it has #include <KDialog> in the public header, it prevents > other components from finishing kdelibs4support-free ports, so I ported it. > > RR 121124 then moves it to KTp/Widgets where it belongs. > > > Diffs > ----- > > KTp/contact-info-dialog.h 833c74f > KTp/contact-info-dialog.cpp 47206cd > > Diff: https://git.reviewboard.kde.org/r/121125/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
