----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122428/ -----------------------------------------------------------
(Updated Feb. 4, 2015, 5:55 p.m.) Review request for KDEPIM and Telepathy. Changes ------- Forgot to upload the patch... Repository: libkpeople Description ------- Move the private methods into the p-impl. First, it's the correct thing to do. Secondly, it was pulling an awkward dependency on abstractcontact.h from the backends into a public header. Diffs (updated) ----- src/CMakeLists.txt d8b4875 src/backends/abstractcontact.h 4d1edcd src/personsmodel.h 239f4ed src/personsmodel.cpp bc2bee6 Diff: https://git.reviewboard.kde.org/r/122428/diff/ Testing ------- Builds, tests pass, ktp-contactlist still works. Thanks, Aleix Pol Gonzalez
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
