----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123064/#review77765 -----------------------------------------------------------
Looks pretty good! CMakeLists.txt <https://git.reviewboard.kde.org/r/123064/#comment53349> Do we actually need exceptions? libktpcall/call-channel-handler.cpp <https://git.reviewboard.kde.org/r/123064/#comment53350> qCWarning() (see the other review) libktpcall/private/device-element-factory.cpp <https://git.reviewboard.kde.org/r/123064/#comment53351> qCDebug (and all the others too) libktpcall/private/sink-controllers.cpp <https://git.reviewboard.kde.org/r/123064/#comment53352> Use QStringLiteral --> QStringLiteral("src%1").arg(... libktpcall/private/tf-audio-content-handler.cpp <https://git.reviewboard.kde.org/r/123064/#comment53353> QStringLiteral libktpcall/private/tf-audio-content-handler.cpp <https://git.reviewboard.kde.org/r/123064/#comment53354> You /could/ possibly do QLatin1String("input_tee_") + QLatin1String(id)? Otherwise QStringLiteral src/dtmf-qml.cpp <https://git.reviewboard.kde.org/r/123064/#comment53355> QStringLiteral instead of QL1String - Martin Klapetek On March 19, 2015, 8:12 p.m., Niels Ole Salscheider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123064/ > ----------------------------------------------------------- > > (Updated March 19, 2015, 8:12 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-call-ui > > > Description > ------- > > Get rid of KDELibs4Support > > > Diffs > ----- > > CMakeLists.txt 873dd93eba18e046b20d89a16d4c843f31377a22 > libktpcall/CMakeLists.txt 512c9f1476636487bd3165bc599d0ca703c62398 > libktpcall/call-channel-handler.cpp > 8779b602028b6812892b5c1a8fb01300781eee7a > libktpcall/call-content-handler.cpp > d167835693d6429da11f7f55cd99af92ba7e0d5d > libktpcall/private/device-element-factory.cpp > 2d425003a98f87cf45695220bbddf6eb15ffa4c2 > libktpcall/private/phonon-integration.cpp > ece6a8b63020ae23cdff202c32942843ed46aa6c > libktpcall/private/sink-controllers.cpp > 7ed56139feda9cc73a7366a771ebf63f0aa278bf > libktpcall/private/sink-manager.cpp > 1df1c1734d4616bbb15e0cd90a34dad428ef9bde > libktpcall/private/tf-audio-content-handler.cpp > 965c19ce2ff057430298d4c4aca5a83d6e7641f3 > libktpcall/private/tf-channel-handler.cpp > 9d906c571e16323dc8bf8b26b77bad864556ba19 > libktpcall/private/tf-content-handler.cpp > a8456e2ccce20ea3076cdd97c21ccf2c5e37c898 > libktpcall/private/tf-video-content-handler.cpp > a8a9eca2a8eb88bb3140643f66529d410bc7087c > libktpcall/private/video-sink-bin.cpp > 0b95b5c4a4cb30d4aca4ad93cc940f47bb5d9769 > libktpcall/tests/CMakeLists.txt f0377cc5f5873624a62714922284ab1c8375876c > libktpcall/tests/configuration_test.cpp > 6b5da6b0e325cda0509a35b862071424807f8cd9 > libqtf/CMakeLists.txt d8841c2590015271489fa7e5c9d5a2e1c3ae69df > src/CMakeLists.txt 3cb382648243129a2126cd546059786a4f1fbc77 > src/approver.h 442ca3fa426f7d01fa90c7b9174e35c74d490ff7 > src/approver.cpp cab426b7f1241190bb3bfa1b0062aea9e06be8b6 > src/call-handler.cpp 75c798491058e0bdd29b0a7618baf86b17048f5c > src/call-manager.cpp df6e7017f9fb6248c5e5488eb45f7c891d18aa0f > src/call-window.cpp b4d7e3dfe0b6ded113c9ff7c226f4a3c2cf2d9f4 > src/dialout/CMakeLists.txt 242fc2b9691875bf8b285c61849d7c9c7dd6e396 > src/dialout/dialout-widget.cpp 2cf5e7f28519f573a3eac1587bc0034a602c46b4 > src/dialout/dialout-widget.ui 2ce4793aa5ffe9a1c2dfa1d4363a687f9b873348 > src/dtmf-qml.cpp PRE-CREATION > src/qml-interface.cpp PRE-CREATION > src/status-area.h bf7bdf5572857f438597914a0bc35c3124ee4637 > src/status-area.cpp b8a36d3855ee9ab67a8e3ad6107e9e3615a41148 > > Diff: https://git.reviewboard.kde.org/r/123064/diff/ > > > Testing > ------- > > Builds, starts. > > > Thanks, > > Niels Ole Salscheider > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
