----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123185/#review78233 -----------------------------------------------------------
Ship it! Ship It! - Eike Hein On March 30, 2015, 4:31 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123185/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 4:31 p.m.) > > > Review request for Telepathy and Eike Hein. > > > Repository: ktp-common-internals > > > Description > ------- > > When the contact is offline, special action is returned which will first > connect the account and then start the chat. > > This is done for text chat only as there is no way of knowing if the target > contact has a support for audio/video calls before it's connected, while text > chats will work in 98% of the cases. > > > Diffs > ----- > > kpeople/actionsplugin/CMakeLists.txt f0f4dd5 > kpeople/actionsplugin/kpeople-actions-plugin.h b80bef8 > kpeople/actionsplugin/kpeople-actions-plugin.cpp d065840 > > Diff: https://git.reviewboard.kde.org/r/123185/diff/ > > > Testing > ------- > > Went offline, selected the action from contact list's context menu, > everything worked as expected. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
